Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Chroma's Database feature. #16

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Nov 26, 2024

Different collections can be in different databases. Passing the
optional database argument at client creation time binds the client to
the appropriate database.

Different collections can be in different databases.  Passing the
optional database argument at client creation time binds the client to
the appropriate database.
Copy link
Owner

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rescrv. Thanks for contributing.
Though this is a breaking change, I think we should do it. Since we had a major version bump recently, we can call out the BREAKING change in the release notes with a minor bump.

@rescrv
Copy link
Contributor Author

rescrv commented Nov 26, 2024

Sounds good. I've addressed the test failures. For context I'd like to use this client to benchmark chroma's cloud offering. Having this in the public crate, released soon, would be a big win for me as I won't have to carry the patch. I'm fine carrying the patch until you are ready to merge, though, so no pressure.

Copy link
Owner

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rescrv. We can cut a release instantly after merge.
Could you please update the README.md example with the database property?

@Anush008 Anush008 changed the title Add support for Chroma's Database feature. feat: Add support for Chroma's Database feature. Nov 26, 2024
@Anush008 Anush008 merged commit ef864cb into Anush008:master Nov 26, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
# [1.1.0](v1.0.2...v1.1.0) (2024-11-26)

### Features

* Add support for Chroma's Database feature. ([#16](#16)) ([ef864cb](ef864cb))

## [1.1.0](v1.0.2...v1.1.0) (2024-11-26)

### 🍕 Features

* Add support for Chroma's Database feature. ([#16](#16)) ([ef864cb](ef864cb))
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rescrv rescrv deleted the rescrv/support-database branch November 26, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants