-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Chroma's Database feature. #16
Conversation
Different collections can be in different databases. Passing the optional database argument at client creation time binds the client to the appropriate database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rescrv. Thanks for contributing.
Though this is a breaking change, I think we should do it. Since we had a major version bump recently, we can call out the BREAKING change in the release notes with a minor bump.
Sounds good. I've addressed the test failures. For context I'd like to use this client to benchmark chroma's cloud offering. Having this in the public crate, released soon, would be a big win for me as I won't have to carry the patch. I'm fine carrying the patch until you are ready to merge, though, so no pressure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @rescrv. We can cut a release instantly after merge.
Could you please update the ✅README.md
example with the database
property?
Signed-off-by: Anush008 <[email protected]>
Signed-off-by: Anush008 <[email protected]>
# [1.1.0](v1.0.2...v1.1.0) (2024-11-26) ### Features * Add support for Chroma's Database feature. ([#16](#16)) ([ef864cb](ef864cb)) ## [1.1.0](v1.0.2...v1.1.0) (2024-11-26) ### 🍕 Features * Add support for Chroma's Database feature. ([#16](#16)) ([ef864cb](ef864cb))
🎉 This PR is included in version 1.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Different collections can be in different databases. Passing the
optional database argument at client creation time binds the client to
the appropriate database.