Handling for query or url params in qp/to

[Isaac-Flath]

---

name: Pull Request
about: Allow qp (and therefore .to method) to handle params with ?a=1 or /a situations
title: '[qp improvement] '
labels: 'enhancement'
assignees: 'isaac-flath'

---

Related Issue
Please link to the issue that this pull request addresses. If there isn't one, please create an issue first.

Proposed Changes
Allow qp (and therefore .to method) to handle params with ?a=1 or /a situations

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

[gitnotebooks]

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/638

[jph00]

Will this break for path params with a : in them?

[Isaac-Flath]

@jph00 I've added a test for that now; please double check the new test to make sure that's the behavior we should be expecting!

[jph00]

I would expect to be using ab as the key - the bit after the : isn't really part of the name IMO; wdyt?

[jph00]

@Isaac-Flath just making sure you saw my comment above.

[Isaac-Flath]

@jph00 I think this looks good now - What do you think?

[jph00]

It's not perfect, but it's a fine start so I'll merge and we can discuss improvements.