Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD-975] Add config button #1077

Merged

Conversation

RisingOrange
Copy link
Collaborator

Users can access the Config dialog from the AnkiHub Menu. Still, we are going to add a shortcut to the sidebar make it easier (and understandable) for the users on how to configure the sidebar to show/hide items.

Related issues

https://ankihub.atlassian.net/browse/BUILD-975

Proposed changes

  • Add config button to the sidebar header which opens the config dialog when clicked

How to reproduce

  • Open the sidebar
  • Click the button
  • The config dialog should open

Screenshots and videos

@RisingOrange RisingOrange requested a review from a team January 15, 2025 12:01
abdnh
abdnh previously approved these changes Jan 15, 2025
@abdnh
Copy link
Contributor

abdnh commented Jan 15, 2025

Unrelated to this PR: two sidebars are being opened. Any idea what's wrong?

image

@RisingOrange
Copy link
Collaborator Author

Unrelated to this PR: two sidebars are being opened. Any idea what's wrong?

image

Can you reproduce this reliably? I have never seen this yet

@RisingOrange
Copy link
Collaborator Author

@abdnh Maybe you have two version of the add-on installed? It might have happened when you logged in via the Anki preferences, because this installs the add-on

@abdnh
Copy link
Contributor

abdnh commented Jan 16, 2025

It might have happened when you logged in via the Anki preferences, because this installs the add-on

Yeah, that's it 😅

@RisingOrange RisingOrange merged commit df82d16 into main Jan 16, 2025
7 checks passed
@RisingOrange RisingOrange deleted the feat/BUILD-975-add-configuration-button-to-sidebar-header branch January 16, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants