Refactor to only make a chatbot request when clicking on the button (#…

…1066)
AnkiHubSoftware · Jan 8, 2025 · 0a800d1 · 0a800d1
1 parent 99a7321
commit 0a800d1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/ankihub/gui/menu.py b/ankihub/gui/menu.py
@@ -202,10 +202,6 @@ def login(self):
 
         tooltip("Signed into AnkiHub!", parent=aqt.mw)
         self.close()
-        from .reviewer import reviewer_sidebar
-
-        if reviewer_sidebar:
-            reviewer_sidebar.update_sidebar_content_with_chatbot_url()
 
     def _is_email(self, value):
         return re.fullmatch(

diff --git a/ankihub/gui/reviewer.py b/ankihub/gui/reviewer.py
@@ -297,14 +297,15 @@ def update_chatbot_header_on_sidebar(self):
     def update_sidebar_content_with_chatbot_url(self) -> None:
         ah_nid = ankihub_db.ankihub_nid_for_anki_nid(self.reviewer.card.nid)
 
-        self.url_pages[ResourceType.CHATBOT].setUrl(
-            aqt.QUrl(f"{config.app_url}/ai/chatbot/{ah_nid}/?is_on_anki=true")
-        )
+        self.url_pages[ResourceType.CHATBOT].setUrl(aqt.QUrl(self.chatbot_url))
         if self.content_webview.page() != self.url_pages[ResourceType.CHATBOT]:
             self.content_webview.setPage(self.url_pages[ResourceType.CHATBOT])
             self._update_theme_after_page_load()
         self.last_card_ah_nid = ah_nid
 
+    def set_chatbot_url_by_ah_nid(self, ah_nid) -> None:
+        self.chatbot_url = f"{config.app_url}/ai/chatbot/{ah_nid}/?is_on_anki=true"
+
     def _update_content_webview_theme(self):
         self.content_webview.eval(
             f"localStorage.setItem('theme', '{_ankihub_theme()}');"
@@ -493,9 +494,12 @@ def _notify_ankihub_ai_of_card_change(card: Card) -> None:
     if (
         reviewer_sidebar
         and config.token()
+        and ah_nid
         and ah_nid != reviewer_sidebar.last_card_ah_nid
     ):
-        reviewer_sidebar.update_sidebar_content_with_chatbot_url()
+        reviewer_sidebar.set_chatbot_url_by_ah_nid(ah_nid)
+        if reviewer_sidebar.is_sidebar_open():
+            reviewer_sidebar.update_sidebar_content_with_chatbot_url()
 
 
 def _remove_anking_button(_: Card) -> None:
@@ -594,6 +598,13 @@ def _on_js_message(handled: Tuple[bool, Any], message: str, context: Any) -> Any
             reviewer_sidebar.set_resource_type(ResourceType.CHATBOT)
             if is_active:
                 reviewer_sidebar.update_chatbot_header_on_sidebar()
+                ah_nid = ankihub_db.ankihub_nid_for_anki_nid(context.card.nid)
+                if (
+                    reviewer_sidebar
+                    and config.token()
+                    and ah_nid != reviewer_sidebar.last_card_ah_nid
+                ):
+                    reviewer_sidebar.update_sidebar_content_with_chatbot_url()
                 reviewer_sidebar.open_sidebar()
             else:
                 reviewer_sidebar.close_sidebar()