-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript arguments #59
Conversation
Looks good to me. I did something similar for python lists/tuples, and I left the helpers as script-local functions. I don't indent to extract them, since there are some javascript-specific things, particularly indentation. I'd say this is good enough as it is. Thanks for your work :). |
I've had to make some changes to javascript if-clause handling due to issue #67. Long story, short, I now have a branch called Also note that there's a variable now, |
Splitjoins javascript function arguments.
Implementation is simply done by extracting and reusing functions already present inside
js.vim
. It might be even more generalizable by moving these helper functions to the mainsj
helper 'module', but this decision I would leave to you, @AndrewRadev.Also fixes minor issues with semicolon handling in javascript. Splitjoining functions were producing js that wouldn't make it through a linter like
jshint
.Note that this currently sits on top of #58 and should not be merged. Depending on the fate of #58 I would rebase or cherry-pick this accordingly before taking further action.
Closes #53