Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Ignore stack lines from outside our test code #51

Conversation

cspotcode
Copy link
Contributor

@cspotcode cspotcode commented Oct 27, 2018

Splitting #40 into multiple PRs for easier review.

This stops the tests from breaking with Node.js updates.

jbunton-atlassian and others added 2 commits October 27, 2018 15:43
This stops the tests from breaking with Node.js updates.
@AndreasMadsen
Copy link
Owner

This makes the test too relaxed. It was this way a long time ago, but there are some bugs related to removing lines that this won't test for.

@cspotcode
Copy link
Contributor Author

Ok, would you like a PR that fixes failing tests by updating them for node v11, the version being used by the TravisCI tests?

@AndreasMadsen
Copy link
Owner

Sure, we can do that. I don't care that much about a green TravisCI myself. I just use git diff as a sanity check that things are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants