-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to reverse scroll direction on workspaces indicator. #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small fix needed before this can be merged
Thank you for the PR! (turns out I had access to commit the fix :p ) |
…ator (#21) * Add option to reverse workspace scroll direction, for natural scrolling users * Fix setting for scroll direction to match hm module setting * Fix missing semicolon in `mithril-shell.nix`
Thanks for accepting it! I'm working on another feature which is fairly big, and I'm wondering if you'd accept a pr on it; a vertical layout. Horizontal bars on an ultrwide display just don't make much sense, they take up precious vertical real estate, and waste too much uneeded horizontal space. I'm making an optional layout which places the bar on the left of the screen. I know it's a pretty big change, and you say this is an opinionated desktop shell, but would you be willing to accept a pr? If not, that's cool, I'll just fork the project. |
That is indeed quite a big change. I'm sorry but I don't think I will accept that PR as I feel this may impact the amount of effort needed to maintain and add new changes by quite a bit. You can of course maintain a fork if you'd like! Thank you for checking in advance and good luck! |
You can ignore this plea for help from a madman who had been chasing a bug for god knows how long. I fixed it. Best of all, I'm not sure how I fixed, but I did. |
Haha I was about to respond but I'm glad you figured it out |
For those who use natural scrolling.