Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to reverse scroll direction on workspaces indicator. #21

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

baduhai
Copy link
Contributor

@baduhai baduhai commented Feb 6, 2025

For those who use natural scrolling.

Copy link
Owner

@AndreasHGK AndreasHGK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small fix needed before this can be merged

modules/mithril-shell.nix Outdated Show resolved Hide resolved
@AndreasHGK AndreasHGK merged commit cf6dbd4 into AndreasHGK:main Feb 6, 2025
@AndreasHGK
Copy link
Owner

AndreasHGK commented Feb 6, 2025

Thank you for the PR! (turns out I had access to commit the fix :p )

AndreasHGK pushed a commit that referenced this pull request Feb 6, 2025
…ator (#21)

* Add option to reverse workspace scroll direction, for natural scrolling users

* Fix setting for scroll direction to match hm module setting

* Fix missing semicolon in `mithril-shell.nix`
@baduhai
Copy link
Contributor Author

baduhai commented Feb 6, 2025

Thanks for accepting it! I'm working on another feature which is fairly big, and I'm wondering if you'd accept a pr on it; a vertical layout.

Horizontal bars on an ultrwide display just don't make much sense, they take up precious vertical real estate, and waste too much uneeded horizontal space. I'm making an optional layout which places the bar on the left of the screen.

I know it's a pretty big change, and you say this is an opinionated desktop shell, but would you be willing to accept a pr? If not, that's cool, I'll just fork the project.

@AndreasHGK
Copy link
Owner

AndreasHGK commented Feb 6, 2025

That is indeed quite a big change. I'm sorry but I don't think I will accept that PR as I feel this may impact the amount of effort needed to maintain and add new changes by quite a bit. You can of course maintain a fork if you'd like!

Thank you for checking in advance and good luck!

@baduhai
Copy link
Contributor Author

baduhai commented Feb 6, 2025

You can ignore this plea for help from a madman who had been chasing a bug for god knows how long. I fixed it.

Best of all, I'm not sure how I fixed, but I did.

@AndreasHGK
Copy link
Owner

Haha I was about to respond but I'm glad you figured it out
I've definitely had a few times where I kept wondering why my config did not work only to realise that if you have a flake in a git repo without any commits it wont notice any changes until you make a first commit. Could be that or could be something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants