Skip to content

Commit

Permalink
[CI] Remove "flarevm.installer.vm"
Browse files Browse the repository at this point in the history
The flarevm.installer.vm package was removed from VM-Packages in
mandiant#752.
As the package does not exit anymore, we can remove it from the test
suite.
  • Loading branch information
Ana06 committed Feb 19, 2024
1 parent 2b5d0b1 commit 9ec2493
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
7 changes: 1 addition & 6 deletions scripts/test/lint.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ def run_cmd(cmd):


class IncludesRequiredFieldsOnly(Lint):
EXCLUSIONS = ["flarevm.installer.vm"]
name = "file lists non-required fields"
allowed_fields = [
"id",
Expand All @@ -92,9 +91,6 @@ class IncludesRequiredFieldsOnly(Lint):
recommendation = f"Only include required fields: {', '.join(allowed_fields)}"

def check(self, path):
if any([exclusion in str(path) for exclusion in self.EXCLUSIONS]):
return False

dom = minidom.parse(str(path))
metadata = dom.getElementsByTagName("metadata")[0]

Expand Down Expand Up @@ -287,7 +283,7 @@ def check(self, path):


class FirstLineDoesNotSetErrorAction(Lint):
EXCLUSIONS = ["libraries.python2.vm", "libraries.python3.vm", "flarevm.installer.vm", "installer.vm"]
EXCLUSIONS = ["libraries.python2.vm", "libraries.python3.vm", "installer.vm"]
FIRST_LINE = "$ErrorActionPreference = 'Stop'"
name = "first line must set error handling to stop"
recommendation = f"add `{FIRST_LINE}` to the file"
Expand All @@ -312,7 +308,6 @@ class UsesInvalidCategory(Lint):
"common.vm",
"debloat.vm",
"dokan.vm",
"flarevm.installer.vm",
"googlechrome.vm",
"ida.plugin.capa.vm",
"idafree.vm",
Expand Down
2 changes: 1 addition & 1 deletion scripts/test/test_install.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ foreach ($package in $packages) {
}


$exclude_tests = @("flarevm.installer.vm", "installer.vm")
$exclude_tests = @("installer.vm")

$failures = New-Object Collections.Generic.List[string]
$failed = 0
Expand Down

0 comments on commit 9ec2493

Please sign in to comment.