fix(tarteaucitron.js): adds a conditionnal for empty lang attribute #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liorchamla
changed the title
|
Nice catch, thanks! 😎 Just need to fix an issue, it's I release this on Monday if ready. |
AmauriC
requested changes
Jul 19, 2024
| @@ -2077,7 +2077,7 @@ var tarteaucitron = { | |||
| } | |||
|
|
|||
| // get the html lang | |||
| if (document.documentElement.getAttribute("lang") !== undefined && document.documentElement.getAttribute("lang") !== null) { | |||
| if (document.documentElement.getAttribute("lang") !== undefined && document.documentElement.getAttribute("lang") !== null && documentElement.getAttribute("lang") !== "") { | |||
There was a problem hiding this comment.
Missing document.
documentElement.getAttribute return ReferenceError: Can't find variable: documentElement
There was a problem hiding this comment.
My bad ! bad copy / paste :'(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So when the
langattribute is empty :<html lang>, thegetLanguagemethod is not able to see it and goes in the conditionnal :And it returns ...
""so the lang script does not load :'(This PR fixes this behavior.