Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from hashicorp:main #188

Open
wants to merge 261 commits into
base: main
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Nov 15, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

jan-mrm and others added 21 commits January 16, 2025 08:23
…ame_for_rotation` (#27791)

* Adds property.
Updates the NodePoolUpdate function to rotate the node pool.
Removes the ForceNew flag on properties.

* Updating tests.
Restoring name as ForceNew.

* Updating Docs.

* Fixing value assignment.
Deleting obsolete methods.
Renaming `retrySystemNodePoolCreation` to `retryNodePoolCreation`.

* Updating properties values from HCL definition.

* Remove unused function (schemaNodePoolSysctlConfigForceNew)

* Fixing docs

* Update pointer's function.

* Improving subnet assignment

* Fixing zones not being updated when value was set to null.

* Fixing assigment when value is null

* Restoring files lose on merge.

* Linting

* Adds 'TestAccKubernetesClusterNodePool_updateVmSizeAfterFailureWithTempAndOriginal'

* Adds TestAccKubernetesCluster_updateVmSizeAfterFailureWithTempWithoutOriginal

* Fix test's name.

* Removing deprecated test and applying feedback.

* Applying feedback.

* Removing obsolete code.
* feat: add new resource azurerm_container_registry_credential_set

* fix: set auth_credentials correctly in import test

* refactor: implement review feedback

* refactor: format docs

* chore: update api version in new credential set resource after it has been updated in the main

* chore: add changes from 'make generate'

* refactor: change implementation to SystemAssignedUserAssignedIdentityRequired as discussed in the pull request (but the api will only accept type SystemAssigned)

* refactor: change implementation from SystemAssignedUserAssignedIdentityRequired to SystemAssignedIdentityRequired

* refactor: implement review feedback - import step and key vault in tests. update markdown. update flattenIdentity

* refactor: tf fmt

* refactor: update to now returned ModelSystemAssigned which is now returned because of the implemented workaround in the go-azure-sdk

* Update internal/services/containers/container_registry_credential_set_resource.go

Co-authored-by: stephybun <[email protected]>

---------

Co-authored-by: stephybun <[email protected]>
* fix examples

* fix remaining examples
* split create/update functions
add in guardrails for ensuring subnets have correct delegations when used

* terrafmt

* fixup update

* fixup parse error messages
* update for #27680

* Update CHANGELOG.md for #28465

* Update CHANGELOG.md #27932

* Update CHANGELOG.md for #28505

* Update CHANGELOG.md for #28474

* Update CHANGELOG.md #28516

* Update CHANGELOG for #28456

* Update CHANGELOG.md for #28472

* Update CHANGELOG.md #28307

* Update CHANGELOG.md for #27859

* Update for #28519

* Update for #27791 #27528

* Update CHANGELOG.md for #28527

* update changelog links and generate provider schema

---------

Co-authored-by: jackofallops <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
* Implement 4.0 TODOs

* wip

* wip

* 4.0 updates

* 4.0 updates

* 4.0 updates

* fixed broken tests

* new sso property

* checkout code changes from main, moving to new PR

* missed corresponding docs changes

* Update website/docs/r/windows_function_app_slot.html.markdown

Co-authored-by: sreallymatt <[email protected]>

* Update website/docs/r/key_vault.html.markdown

Co-authored-by: jackofallops <[email protected]>

---------

Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: jackofallops <[email protected]>
…ith Basic plan (#28550)

The previous link points at article "Select a table plan based on
data usage in a Log Analytics workspace" with general
discussion of configuration.
Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
…destroy (#27950)

* azurerm_backup_protected_vm - protection can now be suspended during destroy

* make terrafmt

* fix unit tests

* fix unit tests

* Update internal/services/recoveryservices/backup_protected_vm_resource.go

Co-authored-by: Matthew Frahry <[email protected]>

* fix test with duplicate azurerm provider block

* Fix TestAccBackupProtectedVm_protectionSuspendedOnDestroy

* Address review

---------

Co-authored-by: Matthew Frahry <[email protected]>
* Adds new data source, including test and docs.

* Empty line

* gofumpt-ing

* Apply feedback and update docs accordingly.

* Fix format

* Fix test and missing field in the data source.
Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
object_id has change to principal_id i azure_role_assignment and azurerm_kubernetes_cluster.example.identity[0]
wuxu92 and others added 6 commits January 27, 2025 15:30
* AKS: fix load_balancer_profile block documentation

* Update website/docs/r/kubernetes_cluster.html.markdown

Co-authored-by: stephybun <[email protected]>

---------

Co-authored-by: stephybun <[email protected]>
Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.