feat(extractor): add mapping between localization key and component (localizationKeys) #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 36c1ac0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
matthieu-crouzet
changed the title
1 task
kpanot
reviewed
Oct 17, 2023
|
The new proposed schema is ok for us ! |
matthieu-crouzet
force-pushed
the
feat/extractor-localization-component-bis
branch
from
8ba1bda to
802baeb
Compare
kpanot
reviewed
Oct 17, 2023
matthieu-crouzet
force-pushed
the
feat/extractor-localization-component-bis
branch
2 times, most recently
from
a37894d to
68ac510
Compare
kpanot
previously approved these changes
Oct 17, 2023
packages/@o3r/localization/builders/helpers/localization.generator.ts
Outdated
Show resolved
Hide resolved
matthieu-crouzet
force-pushed
the
feat/extractor-localization-component-bis
branch
from
68ac510 to
36c1ac0
Compare
kpanot
approved these changes
Oct 18, 2023
fpaul-1A
approved these changes
Oct 18, 2023
matthieu-crouzet
deleted the
feat/extractor-localization-component-bis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add mapping between localization key and component to allow contextualization in CMS
Example of component class metadata
