feat: post message events upon placeholder load #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1739122. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
cpaulve-1A
commented
Oct 13, 2023
packages/@o3r/components/src/stores/placeholder-template/placeholder-template.selectors.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
commented
Oct 13, 2023
packages/@o3r/components/src/tools/placeholder/placeholder.component.ts
Outdated
Show resolved
Hide resolved
kpanot
reviewed
Oct 13, 2023
packages/@o3r/components/src/tools/placeholder/placeholder.component.ts
Outdated
Show resolved
Hide resolved
kpanot
reviewed
Oct 13, 2023
packages/@o3r/components/src/tools/placeholder/placeholder.component.ts
Outdated
Show resolved
Hide resolved
packages/@o3r/components/src/tools/placeholder/placeholder.component.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
force-pushed
the
placeholder-events
branch
2 times, most recently
from
c6fca24 to
c512136
Compare
matthieu-crouzet
previously approved these changes
Oct 13, 2023
cpaulve-1A
force-pushed
the
placeholder-events
branch
from
c512136 to
7c3a159
Compare
kpanot
previously approved these changes
Oct 16, 2023
packages/@o3r/components/src/tools/placeholder/placeholder.interface.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
changed the title
cpaulve-1A
dismissed stale reviews from kpanot and matthieu-crouzet
via
345d547
cpaulve-1A
force-pushed
the
placeholder-events
branch
from
7c3a159 to
345d547
Compare
fpaul-1A
reviewed
Oct 16, 2023
packages/@o3r/components/src/tools/placeholder/placeholder.component.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
force-pushed
the
placeholder-events
branch
from
9a0c1c9 to
b4c9bce
Compare
fpaul-1A
previously approved these changes
Oct 17, 2023
kpanot
reviewed
Oct 17, 2023
packages/@o3r/components/src/tools/placeholder/placeholder.component.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
force-pushed
the
placeholder-events
branch
from
b4c9bce to
e215068
Compare
matthieu-crouzet
previously approved these changes
Oct 19, 2023
fpaul-1A
previously approved these changes
Oct 19, 2023
kpanot
reviewed
Oct 19, 2023
packages/@o3r/components/src/tools/placeholder/placeholder.component.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
dismissed stale reviews from fpaul-1A and matthieu-crouzet
via
ae30e21
cpaulve-1A
force-pushed
the
placeholder-events
branch
from
e215068 to
ae30e21
Compare
kpanot
reviewed
Oct 19, 2023
packages/@o3r/components/src/tools/placeholder/placeholder.interface.ts
Outdated
Show resolved
Hide resolved
…erface.ts Co-authored-by: Kilian Panot <[email protected]>
fpaul-1A
approved these changes
Oct 20, 2023
kpanot
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add message events to inform third parties of placeholder updates
Related issue