feat: captcha support on sdk plugins #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 85e29e6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
kpanot
reviewed
Aug 22, 2023
cpaulve-1A
force-pushed
the
feat/captcha-support
branch
3 times, most recently
from
d2cfa73 to
d5a9fe6
Compare
cpaulve-1A
force-pushed
the
feat/captcha-support
branch
from
d5a9fe6 to
d5e5647
Compare
cpaulve-1A
force-pushed
the
feat/captcha-support
branch
from
78a66b2 to
a94bd88
Compare
cpaulve-1A
force-pushed
the
feat/captcha-support
branch
from
a94bd88 to
5092f65
Compare
cpaulve-1A
commented
Sep 5, 2023
cpaulve-1A
force-pushed
the
feat/captcha-support
branch
2 times, most recently
from
14d33f7 to
f6f74f1
Compare
cpaulve-1A
force-pushed
the
feat/captcha-support
branch
from
f6f74f1 to
fb6c2a9
Compare
kpanot
reviewed
Dec 11, 2023
fpaul-1A
reviewed
Dec 12, 2023
fpaul-1A
reviewed
Dec 12, 2023
fpaul-1A
reviewed
Dec 12, 2023
fpaul-1A
reviewed
Dec 12, 2023
cpaulve-1A
force-pushed
the
feat/captcha-support
branch
2 times, most recently
from
58fa7e6 to
578e911
Compare
cpaulve-1A
force-pushed
the
feat/captcha-support
branch
from
578e911 to
85e29e6
Compare
fpaul-1A
approved these changes
Dec 13, 2023
| @@ -1,12 +1,12 @@ | |||
| import {EmptyResponseError, ResponseTimeoutError} from '../../fwk/errors'; | |||
| import {TimeoutFetch} from './timeout.fetch'; | |||
| import {TimeoutFetch, TimeoutStatus} from './timeout.fetch'; | |||
There was a problem hiding this comment.
isn't TimeoutStatus a type?
kpanot
approved these changes
Dec 14, 2023
| /** | ||
| * Factory to generate a {@see TimeoutPauseEventHandler} depending on various configurations | ||
| */ | ||
| export type TimeoutPauseEventHandlerFactory<T> = (config?: Partial<T>) => TimeoutPauseEventHandler; |
There was a problem hiding this comment.
You can add a constraint on T as T extends Record<string, any>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Stop and restart the timeout fetch plugin in case a specific event interrumpts the fetch request.
Add event emitter to pause the timeout if an imperva captcha has been detected.