fix: remove deprecated vars for templates #2742
Merged
+5
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit cd2cd05.
☁️ Nx Cloud last updated this comment at |
sdo-1A
approved these changes
Jan 27, 2025
kpanot
approved these changes
Jan 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
| @@ -11,7 +11,6 @@ import { | |||
| export interface PlaceholderVariable { | |||
| type: 'fact' | 'fullUrl' | 'relativeUrl' | 'localisation'; | |||
| value: string; | |||
| vars?: string[]; | |||
There was a problem hiding this comment.
We forgot to deprecate it here.. :/
matthieu-crouzet
approved these changes
Jan 27, 2025
amadeus-pmeneguzzi
approved these changes
Jan 28, 2025
vscaiceanu-1a
force-pushed
the
feature/remove-vars-templates
branch
from
b23d51b to
cd2cd05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Follow up for #1587, removing deprecated
varsused in placeholder templates.Documentation has been already updated 18470a5#diff-84b1c82a9c6fd7aaf05809ae0ad3020bdaf415d9b37ad73029fe22999ebfbb26