Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspace): the tsconfig links to generate libraries #2648

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Dec 23, 2024

Proposed change

fix(workspace): the tsconfig links to generate libraries

It fixes the following points:

  • generate the tsconfig.build.json (mandatory for lib standalone publishing)
  • remove the dist/ path from the tsconfig.base.json which is leading to wrong path mapping when the library was locally built
  • register properly the lib in both tsconfig files
  • update the tsconfig.lib.prod.json to extend the correct tsconfig

Related issues

@kpanot kpanot requested a review from a team as a code owner December 23, 2024 05:20
Copy link

nx-cloud bot commented Dec 23, 2024

View your CI Pipeline Execution ↗ for commit c4bfafb.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 8m 40s View ↗
nx run-many --target=test-e2e ✅ Succeeded 10m 47s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 1m 50s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 19s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 14s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
nx run-many --target=build ✅ Succeeded 40s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-24 14:11:48 UTC

@github-actions github-actions bot added bug Something isn't working project:@o3r/workspace labels Dec 23, 2024
@kpanot kpanot force-pushed the bugfix/library-generation branch from d9c04af to e73788e Compare December 23, 2024 07:42
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.32%. Comparing base (d39f20e) to head (c4bfafb).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...o3r/workspace/schematics/library/rules/rules.ng.ts 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpanot kpanot force-pushed the bugfix/library-generation branch from e73788e to 3c0f4c7 Compare January 7, 2025 14:57
@kpanot kpanot force-pushed the bugfix/library-generation branch from 3c0f4c7 to e99e48b Compare January 7, 2025 16:08
fpaul-1A
fpaul-1A previously approved these changes Jan 7, 2025
vscaiceanu-1a
vscaiceanu-1a previously approved these changes Jan 9, 2025
@kpanot kpanot force-pushed the bugfix/library-generation branch 2 times, most recently from 0b7e199 to f50c03e Compare January 10, 2025 00:34
@kpanot kpanot force-pushed the bugfix/library-generation branch from f50c03e to c4bfafb Compare January 24, 2025 13:44
@kpanot kpanot enabled auto-merge January 24, 2025 13:55
@kpanot kpanot added this pull request to the merge queue Jan 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 24, 2025
@kpanot kpanot added this pull request to the merge queue Jan 25, 2025
Merged via the queue into main with commit e77dc8f Jan 25, 2025
37 checks passed
@kpanot kpanot deleted the bugfix/library-generation branch January 25, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project:@o3r/workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: tsconfig.base.json and tsconfig.build.json are not properly generated
4 participants