Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: o3r pipeline #2207

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat: o3r pipeline #2207

merged 1 commit into from
Oct 21, 2024

Conversation

vscaiceanu-1a
Copy link
Member

Proposed change

Related issues

@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/o3r-pipeline branch 5 times, most recently from 92f19d6 to 8c420ce Compare October 1, 2024 10:30
@vscaiceanu-1a vscaiceanu-1a marked this pull request as ready for review October 1, 2024 12:07
@vscaiceanu-1a vscaiceanu-1a requested a review from a team as a code owner October 1, 2024 12:07
packages/@o3r/pipeline/project.json Outdated Show resolved Hide resolved
packages/@o3r/pipeline/project.json Outdated Show resolved Hide resolved
packages/@o3r/pipeline/package.json Outdated Show resolved Hide resolved
packages/@o3r/pipeline/package.json Outdated Show resolved Hide resolved
packages/@o3r/pipeline/package.json Outdated Show resolved Hide resolved
packages/@o3r/pipeline/.gitignore Outdated Show resolved Hide resolved
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/o3r-pipeline branch 2 times, most recently from acbc90d to 997e5db Compare October 2, 2024 07:19
.renovaterc.json5 Outdated Show resolved Hide resolved
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/o3r-pipeline branch 3 times, most recently from e458387 to 2f7990f Compare October 2, 2024 14:40
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/o3r-pipeline branch 2 times, most recently from 1ed4e91 to 18abb51 Compare October 16, 2024 14:52
kpanot
kpanot previously approved these changes Oct 17, 2024
packages/@o3r/pipeline/README.md Outdated Show resolved Hide resolved
packages/@o3r/pipeline/README.md Outdated Show resolved Hide resolved
runner: string;

/** A custom npm registry */
npmRegistry?: string | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to specify | undefined if you use ? at the end of the variable name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back in the day we had an issue:

interface I {
  a?: string;
}

// valid:
const v1: I = {};

// invalid:
const v2: I = { a: undefined };

but with explicit undefined:

interface I {
  a?: string | undefined;
}

// valid:
const v1: I = {};
const v2: I = { a: undefined };

tools/@o3r/build-helpers/scripts/write-git-hash.mjs Outdated Show resolved Hide resolved
packages/@o3r/pipeline/schematics/ng-add/index.ts Outdated Show resolved Hide resolved
packages/@o3r/pipeline/schematics/ng-add/index.ts Outdated Show resolved Hide resolved
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/o3r-pipeline branch 2 times, most recently from 1187824 to 4c75fe9 Compare October 17, 2024 13:04
fpaul-1A
fpaul-1A previously approved these changes Oct 17, 2024
fpaul-1A
fpaul-1A previously approved these changes Oct 18, 2024
@vscaiceanu-1a vscaiceanu-1a added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 47ab061 Oct 21, 2024
29 checks passed
@vscaiceanu-1a vscaiceanu-1a deleted the feature/o3r-pipeline branch October 21, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants