-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: o3r pipeline #2207
Merged
Merged
feat: o3r pipeline #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92f19d6
to
8c420ce
Compare
fpaul-1A
reviewed
Oct 1, 2024
...ages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/actions/setup/action.yml
Show resolved
Hide resolved
kpanot
reviewed
Oct 1, 2024
...ages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/actions/setup/action.yml
Show resolved
Hide resolved
packages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/workflows/main.yml
Outdated
Show resolved
Hide resolved
packages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/workflows/main.yml
Outdated
Show resolved
Hide resolved
kpanot
reviewed
Oct 1, 2024
packages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/workflows/main.yml
Outdated
Show resolved
Hide resolved
packages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/workflows/main.yml
Outdated
Show resolved
Hide resolved
packages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/workflows/main.yml
Outdated
Show resolved
Hide resolved
...ages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/actions/setup/action.yml
Outdated
Show resolved
Hide resolved
acbc90d
to
997e5db
Compare
kpanot
reviewed
Oct 2, 2024
997e5db
to
530a18a
Compare
kpanot
reviewed
Oct 2, 2024
e458387
to
2f7990f
Compare
kpanot
reviewed
Oct 2, 2024
packages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/workflows/main.yml
Outdated
Show resolved
Hide resolved
2f7990f
to
f82d071
Compare
kpanot
reviewed
Oct 7, 2024
...ages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/actions/setup/action.yml
Show resolved
Hide resolved
f82d071
to
25babf8
Compare
fe2c92a
to
aea27be
Compare
kpanot
reviewed
Oct 16, 2024
kpanot
reviewed
Oct 16, 2024
1ed4e91
to
18abb51
Compare
kpanot
reviewed
Oct 16, 2024
18abb51
to
0d54ca7
Compare
0d54ca7
to
d35272a
Compare
kpanot
reviewed
Oct 17, 2024
kpanot
previously approved these changes
Oct 17, 2024
sdo-1A
reviewed
Oct 17, 2024
runner: string; | ||
|
||
/** A custom npm registry */ | ||
npmRegistry?: string | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need to specify | undefined
if you use ?
at the end of the variable name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
back in the day we had an issue:
interface I {
a?: string;
}
// valid:
const v1: I = {};
// invalid:
const v2: I = { a: undefined };
but with explicit undefined:
interface I {
a?: string | undefined;
}
// valid:
const v1: I = {};
const v2: I = { a: undefined };
fpaul-1A
reviewed
Oct 17, 2024
packages/@o3r/pipeline/schematics/ng-add/templates/github/__dot__github/workflows/main.yml
Outdated
Show resolved
Hide resolved
1187824
to
4c75fe9
Compare
fpaul-1A
previously approved these changes
Oct 17, 2024
kpanot
reviewed
Oct 17, 2024
4c75fe9
to
4fe55b0
Compare
fpaul-1A
previously approved these changes
Oct 18, 2024
4fe55b0
to
612fcf2
Compare
kpanot
approved these changes
Oct 21, 2024
fpaul-1A
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Related issues