fix(showcase): lighthouse accessibility report #1138
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5219fec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
fpaul-1A
force-pushed
the
fix/showcase-lighthouse
branch
from
202e771 to
5219fec
Compare
| @@ -30,8 +30,10 @@ <h2 id="configuration-examples">Examples</h2> | |||
| <div class="row"> | |||
| <o3r-copy-text-pres language="html" [text]="codeConfig()" class="col-12 col-md-8 col-lg-9"></o3r-copy-text-pres> | |||
| <div class="d-flex gap-2 align-self-start mt-md-2 pb-3 col-12 col-md-4 col-lg-3"> | |||
| <button type="button" class="btn btn-primary" [class.disabled]="config()" (click)="toggleConfig()">Override</button> | |||
| <button type="button" class="btn btn-danger" [class.disabled]="!config()" (click)="toggleConfig()">Clear</button> | |||
| <button type="button" class="btn btn-primary" disabled="{{config()}}" | |||
There was a problem hiding this comment.
[attr.disabled]="config()"
not mandatory
| @@ -11,7 +11,7 @@ <h2 class="bg-body-tertiary text-secondary border border-light-subtle border-3 r | |||
| <div aria-hidden="true" class="bg-body-tertiary position-absolute start-0 top-50 border border-light-subtle border-3 border-end-0 border-bottom-0"></div> | |||
| </h2> | |||
| </div> | |||
| <h5 class="row card-text mt-auto ms-1">Where do you want to go?</h5> | |||
| <h3 class="row card-text mt-auto ms-1 h5">Where do you want to go?</h3> | |||
There was a problem hiding this comment.
Do we really want to keep headings in the showcase components ?
Because they are not heading related to the app but only for a showcase purpose
There was a problem hiding this comment.
either way the headings needs to accurately define the structure of the page, which I think is the case here
I can change it if you disagree
There was a problem hiding this comment.
Yes, I agree it is the good value according to the structure of the page.
Maybe we should use <p> or <div> instead <h[x]> in these showcase components.
As you want :)
Proposed change
Fixes deployed here https://fpaul-1a.github.io/otter
Related issues