feat: matches basic operator

[sdo-1A]

Proposed change

Currently it is not possible to have in the conditions something like the following:

stringFact matches pattern

Where "stringFact" is whatever string and "pattern" is a regular expression like "/^8[0-9]{3}/"

Related issues

• 🚀 Feature [Feature]: "Matches" as a basic operator for strings in rules #1120

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c4aee84. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many --target=build --projects=eslint-plugin,dev-tools --parallel 3

---

Sent with 💌 from NxCloud.

[kpanot]

Not as simple: new RegExp('/a/i') is not equivalent to /a/i but /\/a\/i/.
You will need to handle the 2 / of the regexp and the options given in the end (that are the second parameter of the new RegExpp())

[kpanot]

can be instantiated without be used.

    if (inputString.startWith('/')) {
      const finalSlash = inputString.lastIndexOf('/');
      const regexpContent = inputString.slice(1, finalSlash);
      const regexpOption = inputString.slice(finalSlash + 1);
      return new RegExp(regexpContent, regexpOption);
    }
    return new RegExp(inputString);

[kpanot]

You should also specify that you support /^myRegExp.*$/i(ES RegExp) and ^myregexp.*$ (regexp content).
(also, with my suggestion, the \\/ is not mandatory, it is already not mandatory in the regexp content format)

[cpaulve-1A]

What if you want to match an url, wouldn't it detect it as a regex? Ex: /this/is/a/url.com

Would that be a valid scenario?

[sdo-1A]

That is a good point, I will add to the documentation that a parameter of type regexp content that begins with a / should be preceded by \ to avoid a wrong detection

[cpaulve-1A]

while that is correct and would work as a mitigation, I wonder if it does not make sense to apply your logic if the inputString begins and ends with a '/' ?

[kpanot]

Reduce the cost if you instantiate the regExp only once:

Suggested change

	return array.every((elementValue) => RegExp(inputString).test(elementValue));
	const regExp = new RegExp(inputString);
	return array.every((elementValue) => regExp.test(elementValue));

[fpaul-1A]

this logic seems to be duplicated 3 times, might be good to extract the code in an helper

const inputRegExp = parseRegExp(inputString);

or something

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4a64581. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 9 targets

• nx run-many --target=test-int --parallel 2 --output-style=stream
• nx run-many --target=build --projects=eslint-plugin,dev-tools --parallel 3
• nx run-many --target=publish --parallel 3 --nx-bail --access=public --userconfig .verdaccio/conf/.npmrc-logged --tag=latest --@o3r:registry=http://127.0.0.1:4873 --@ama-sdk:registry=http://127.0.0.1:4873 --@ama-terasu:registry=http://127.0.0.1:4873
• nx affected --target=test --parallel 2 --cacheDirectory=D:\a\otter\otter/.cache/jest --base=remotes/origin/main --output-style=stream
• nx affected --target=test --parallel 2 --cacheDirectory=/home/runner/work/otter/otter/.cache/jest --base=remotes/origin/main --output-style=stream
• nx run-many --target=build --parallel 3
• nx run ama-sdk-generator-sdk:build-swagger
• nx affected --target=lint --parallel 3 --base=remotes/origin/main --configuration ci
• nx run-many --target=build-swagger --parallel 3

---

Sent with 💌 from NxCloud.