Skip to content

Commit

Permalink
fix: remove deprecated prepareRuleset method (#1362)
Browse files Browse the repository at this point in the history
## Proposed change

Follow up on #1044

The comment mentions that it should be removed in v10.

If it's too early we can do it in v12.
  • Loading branch information
vscaiceanu-1a authored Feb 19, 2024
2 parents 0e9d7f1 + f9e5795 commit 3f482f9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion packages/@o3r/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
"@nx/eslint-plugin": "~18.0.2",
"jsonc-eslint-parser": "~2.4.0",
"eslint-import-resolver-node": "^0.3.4",
"eslint-plugin-jest": "~27.8.0",
"eslint-plugin-jest": "~27.9.0",
"eslint-plugin-jsdoc": "~48.1.0",
"eslint-plugin-prefer-arrow": "~1.2.3",
"eslint-plugin-unicorn": "^51.0.0",
Expand Down
8 changes: 0 additions & 8 deletions packages/@o3r/rules-engine/src/engine/ruleset-executor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -320,12 +320,4 @@ export class RulesetExecutor {
rulesResultsSubject$: result$
} as EngineRuleset;
}

/**
* Plug ruleset to fact streams and trigger a first evaluation
* @deprecated This function is not made to be accessible from Outside of the class, will be removed in v10
*/
public prepareRuleset() {
return this.plugRuleset();
}
}

0 comments on commit 3f482f9

Please sign in to comment.