Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $app/state instead of $app/stores #1084

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quentinderoubaix
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (f5f42f9) to head (fad3a38).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    sveltejs/kit#1084   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files          99       99           
  Lines        2690     2690           
  Branches      444      444           
=======================================
  Hits         2455     2455           
  Misses        156      156           
  Partials       79       79           
Flag Coverage Δ
e2e 82.70% <ø> (ø)
unit 84.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quentinderoubaix quentinderoubaix marked this pull request as draft January 6, 2025 20:37
@quentinderoubaix quentinderoubaix force-pushed the advent-of-svelte branch 2 times, most recently from 888f63d to cd7278f Compare January 7, 2025 09:02
@quentinderoubaix quentinderoubaix marked this pull request as ready for review January 7, 2025 09:17
@quentinderoubaix quentinderoubaix changed the title Use $app/state instead of $app/stores + createSubscriber in coffee brewer demo Use $app/state instead of $app/stores Jan 7, 2025
@quentinderoubaix quentinderoubaix marked this pull request as draft January 7, 2025 12:31
@quentinderoubaix
Copy link
Contributor Author

Let's wait for clarification from sveltejs/svelte#14954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant