Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metastore fields in crd for helm charts #91

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Add metastore fields in crd for helm charts #91

merged 2 commits into from
Nov 27, 2023

Conversation

Kai-Zhang
Copy link
Contributor

No description provided.

@Kai-Zhang Kai-Zhang requested a review from ssz1997 November 23, 2023 10:41
@dxhome dxhome self-requested a review November 24, 2023 02:28
ssz1997
ssz1997 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@ssz1997 ssz1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this in operator.

@ssz1997 ssz1997 merged commit 3f0fef3 into main Nov 27, 2023
1 check passed
@Kai-Zhang Kai-Zhang deleted the zhihu-fix branch January 9, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssz1997 ssz1997 ssz1997 approved these changes

@dxhome dxhome Awaiting requested review from dxhome

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kai-Zhang @ssz1997