Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Prevent saving empty custom model #6149

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

amanape
Copy link
Member

@amanape amanape commented Jan 8, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Extend test files
    image

Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:945fd99-nikolaik   --name openhands-app-945fd99   docker.all-hands.dev/all-hands-ai/openhands:945fd99

@amanape amanape requested a review from mamoodi January 8, 2025 16:20
@amanape amanape self-assigned this Jan 8, 2025
@mamoodi
Copy link
Collaborator

mamoodi commented Jan 8, 2025

Tested this locally and looks good now. Thank you!

@amanape amanape enabled auto-merge (squash) January 8, 2025 16:59
@amanape amanape merged commit 0d409c8 into main Jan 9, 2025
15 checks passed
@amanape amanape deleted the chore/no-submit-empty branch January 9, 2025 13:43
AlexCuadron pushed a commit to AlexCuadron/OpenHands that referenced this pull request Jan 13, 2025
AlexCuadron pushed a commit to AlexCuadron/OpenHands that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants