Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle binary data in GoogleCloudFileStore.write #6145

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Jan 8, 2025

The write operation in GoogleCloudFileStore accepts bytes or string input, but currently fails when given bytes. This PR fixes the issue by using the appropriate mode (wb for bytes, w for strings) when opening the blob for writing.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:ccddd6c-nikolaik   --name openhands-app-ccddd6c   docker.all-hands.dev/all-hands-ai/openhands:ccddd6c

Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@rbren rbren enabled auto-merge (squash) January 8, 2025 16:20
@rbren rbren merged commit 8028e2c into main Jan 8, 2025
14 of 17 checks passed
@rbren rbren deleted the fix/google-cloud-binary-write branch January 8, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants