Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add TypeScript compilation step to frontend workflows #5346

Closed
wants to merge 3 commits into from

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Dec 1, 2024

This PR fixes #5343 by adding TypeScript compilation step to frontend workflows.

The changes:

  1. Add npm run tsc step to both frontend-lint.yml and frontend-tests.yml
  2. This ensures TypeScript errors are caught by frontend workflows before Python unit tests
  3. The step runs before linting/testing to fail fast

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:0ffb9d7-nikolaik   --name openhands-app-0ffb9d7   docker.all-hands.dev/all-hands-ai/openhands:0ffb9d7

@neubig neubig marked this pull request as draft December 1, 2024 16:58
@neubig neubig closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Frontend changes cause Python unit tests workflow to fail but not frontend workflow
2 participants