Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #21 by making listing-titles match links #35

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

jpfairbanks
Copy link
Member

@jpfairbanks jpfairbanks commented Aug 1, 2024

Do you think it is too much? People will certainly know that the names are links now.

Copy link

github-actions bot commented Aug 1, 2024

@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 02:34 Inactive
Copy link
Member

@lukem12345 lukem12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the underline is blue, which seems like a reasonable compromise for aesthetics and denoting clickability.

@jpfairbanks
Copy link
Member Author

When I built this locally it looks like:

image

But now just the underline is blue. Weird

@jpfairbanks jpfairbanks merged commit fb2f2e0 into main Aug 1, 2024
7 checks passed
@jpfairbanks jpfairbanks deleted the jpf/#21 branch August 1, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants