[ACS-5566] - Add configurable columns to document list #8968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikiwanekhyland
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
dominikiwanekhyland
requested review from
swapnil-verma-gl,
MichalKinas and
AleksanderSklorz
eromano
requested changes
Oct 10, 2023
lib/content-services/src/lib/document-list/components/document-list.component.ts
Outdated
Show resolved
Hide resolved
swapnil-verma-gl
approved these changes
Oct 11, 2023
dominikiwanekhyland
force-pushed
the
ACS-5566-adf-configurable-document-list-layouts
branch
from
3f90ba0 to
f7c2b3b
Compare
lib/content-services/src/lib/document-list/components/document-list.component.ts
Outdated
Show resolved
Hide resolved
AleksanderSklorz
approved these changes
Oct 12, 2023
dominikiwanekhyland
force-pushed
the
ACS-5566-adf-configurable-document-list-layouts
branch
2 times, most recently
from
40d0c88 to
2a9ea02
Compare
MichalKinas
approved these changes
Oct 12, 2023
dominikiwanekhyland
force-pushed
the
ACS-5566-adf-configurable-document-list-layouts
branch
from
2a9ea02 to
1d9108e
Compare
dominikiwanekhyland
force-pushed
the
ACS-5566-adf-configurable-document-list-layouts
branch
from
1d9108e to
530f66a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
DenysVuika
reviewed
Oct 24, 2023
lib/content-services/src/lib/document-list/components/document-list.component.spec.ts
Show resolved
Hide resolved
DenysVuika
approved these changes
Oct 24, 2023
DenysVuika
deleted the
ACS-5566-adf-configurable-document-list-layouts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
In document list component columns are static. Once configured via html or json, they can't be configured by end user
What is the new behaviour?
Document list component has possiblity to hide/show columns. Columns hidden by default have their property 'isHidden' both in component's inputs properties and in json. Maximum amount of visible columns is limited.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: