[ACS-9166] Migrate Saved Searches to preferences API from config file #10559
+171
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalKinas
requested review from
nikita-web-ua,
swapnil-verma-gl,
AleksanderSklorz and
dominikiwanekhyland
MichalKinas
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
dominikiwanekhyland
approved these changes
Jan 17, 2025
|
| @@ -84,4 +84,25 @@ export class PreferencesApi extends BaseApi { | |||
| queryParams | |||
| }); | |||
| } | |||
|
|
|||
| updatePreference(personId: string, preferenceName: string, preferenceValue: string): Promise<PreferenceEntry> { | |||
There was a problem hiding this comment.
should we have some unit tests for this? I see for other APIs we have unit tests like for tag api file.
There was a problem hiding this comment.
I wonder if we actually need them, to be honest they're quite outdated, a lot of APIs are not covered and maybe for the future we could think of a better solution for this but for now I would not add new unit tests there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Saved Searches will no longer be stored in configuration file in favor of using preferences API. Existing data will be automatically migrated and configuration file will be automatically deleted.
https://hyland.atlassian.net/browse/ACS-9166
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: