Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8960] Review and apply required inputs where possible #4339

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import { MatSlideToggleModule } from '@angular/material/slide-toggle';
host: { class: 'aca-rule-list-item' }
})
export class RuleListItemUiComponent {
@Input()
@Input({ required: true })
rule: Rule;
@Input()
@HostBinding('class.aca-selected')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
host: { class: 'aca-rule-list' }
})
export class RuleListUiComponent implements OnInit {
@Input()
@Input({ required: true })
mainRuleSet$: Observable<RuleSet>;
@Input()
@Input({ required: true })
folderId: string;
@Input()
inheritedRuleSets: RuleSet[] = [];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
standalone: true
})
export class DatatableCellBadgesComponent implements OnInit {
@Input() node: NodeEntry;
@Input({ required: true }) node: NodeEntry;

badges: Badge[];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class SearchResultsRowComponent implements OnInit {

private node: NodeEntry;

@Input()
@Input({ required: true })
context: any;

name$ = new BehaviorSubject<string>('');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* from Hyland Software. If not, see <http://www.gnu.org/licenses/>.
*/

import { Component, Input, ViewEncapsulation, OnInit, ChangeDetectorRef } from '@angular/core';
import { ChangeDetectorRef, Component, Input, OnInit, ViewEncapsulation } from '@angular/core';
import { OverlayContainer } from '@angular/cdk/overlay';
import { NavBarLinkRef } from '@alfresco/adf-extensions';
import { CommonModule } from '@angular/common';
Expand All @@ -43,7 +43,7 @@ import { MenuPanelDirective } from '../directives/menu-panel.directive';
encapsulation: ViewEncapsulation.None
})
export class ButtonMenuComponent implements OnInit {
@Input()
@Input({ required: true })
item: NavBarLinkRef;

constructor(private cd: ChangeDetectorRef, private overlayContainer: OverlayContainer) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import { ExpansionPanelDirective } from '../directives/expansion-panel.directive
host: { class: 'app-expand-menu' }
})
export class ExpandMenuComponent implements OnInit {
@Input()
@Input({ required: true })
item: NavBarLinkRef;

@Output()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class InfoDrawerComponent implements OnChanges, OnInit, OnDestroy {
@Input()
nodeId: string;

@Input()
@Input({ required: true })
node: NodeEntry;

isLoading = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import { MatToolbarModule } from '@angular/material/toolbar';
encapsulation: ViewEncapsulation.None
})
export class ToolbarComponent {
@Input() items: ContentActionRef[];
@Input({ required: true }) items: ContentActionRef[];

trackByActionId(_: number, action: ContentActionRef) {
return action.id;
Expand Down
Loading