Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-9102] Local ACS deployment for E2Es #4324

Merged
merged 39 commits into from
Jan 15, 2025
Merged

[ACS-9102] Local ACS deployment for E2Es #4324

merged 39 commits into from
Jan 15, 2025

Conversation

MichalKinas
Copy link
Contributor

@MichalKinas MichalKinas commented Jan 3, 2025 •
edited
Loading

gionn
gionn reviewed Jan 3, 2025
View reviewed changes
.github/workflows/deploy-local-acs.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-local-acs.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-local-acs.yml Outdated Show resolved Hide resolved
gionn
gionn reviewed Jan 14, 2025
View reviewed changes
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
.github/actions/after-e2e/action.yml Outdated Show resolved Hide resolved
.github/actions/deploy-local-acs/action.yml Outdated Show resolved Hide resolved
@MichalKinas MichalKinas changed the title [ACS-9102] Local ACS deployment draft [ACS-9102] Local ACS deployment for E2Es Jan 15, 2025
@MichalKinas MichalKinas marked this pull request as ready for review January 15, 2025 07:32
MichalKinas and others added 24 commits January 15, 2025 09:04
@MichalKinas
[ACS-9102] Local ACS deployment draft
cab167c
@MichalKinas
[ACS-9102] Move ACS deployment to composite action
3b5bf56
@MichalKinas
[ACS-9102] Remove obsolete checks
df03d31
@MichalKinas
[ACS-9102] Proper secrets for ACS deployment
eddb4b4
@MichalKinas
[ACS-9102] Add required shell property
7835348
@MichalKinas
[ACS-9102] Use fixed acs deployment version
8cea9d0
@MichalKinas
[ACS-9102] Proper acs deployment tag
15793c8
@MichalKinas
[ACS-9102] Add required shell property
35005a9
@MichalKinas
[ACS-9102] Fix helm install params
177a777
@MichalKinas
[ACS-9102] Remove obsolete checkout
4c2a0b4
@MichalKinas
[ACS-9102] Use more powerful runner for E2Es
2879b8e
@MichalKinas
[ACS-9102] Introduce temp secrets
509bb18
@gionn @MichalKinas
test curl localhost
321ac81
@gionn @MichalKinas
skip n-1 matrix jobs
3d8cfb6
@gionn @MichalKinas
test ipv4 first
a62040c
@MichalKinas
[ACS-9102] Adjust Playwright E2E host
b64c592
@MichalKinas
[ACS-9102] Bring back matrix job
99d8160
@gionn @MichalKinas
disable unnecessary acs components
3cbe1f5
@gionn @MichalKinas
debug ingress after tests run
6b57e26
@MichalKinas
[ACS-9102] Fix folder-rules test suite
46ae848
@MichalKinas
[ACS-9102] Fix part of viewer test suite
fd54a0d
@MichalKinas
[ACS-9102] Additional E2E fixes
99eeb70
@datguychen @MichalKinas
[ACS-9102] fixes for e2es -> empty-list and search
d5c184e
@datguychen @MichalKinas
[ACS-9102] more fixes for e2es and github actions artifacts added for…
359004b 
… easier debugging
@MichalKinas MichalKinas force-pushed the feature/dev-mkinas-ACS-9102 branch from 425925e to 373acd2 Compare January 15, 2025 08:08
@AleksanderSklorz
Copy link
Contributor

@MichalKinas can you fix sonar issues?
image

@MichalKinas
Copy link
Contributor Author

@MichalKinas can you fix sonar issues? image

Those duplications are coming from E2Es and fixing this would increase the risk of unstable E2Es since we would need to run them in a loop, I discussed that with Adam and he did the same in past with Denys we all agree that this approach is better even if Sonar think the code is a bit duplicated

@AleksanderSklorz
Copy link
Contributor

@MichalKinas can you fix sonar issues? image

Those duplications are coming from E2Es and fixing this would increase the risk of unstable E2Es since we would need to run them in a loop, I discussed that with Adam and he did the same in past with Denys we all agree that this approach is better even if Sonar think the code is a bit duplicated

ok, thanks for explanation

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@MichalKinas MichalKinas merged commit 8931a29 into develop Jan 15, 2025
25 of 26 checks passed
@MichalKinas MichalKinas deleted the feature/dev-mkinas-ACS-9102 branch January 15, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@gionn gionn gionn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichalKinas @AleksanderSklorz @gionn @datguychen