Sonarcloud issues fixes (#3499)

* Sonarcloud issues fixes * Code smell fixes * Refactoring to remove new code duplications * Sonarcloud code smell fixes part I * Sonarcloud code smell fixes part II * Missing code smell fix * Add new ESLint rules to cover fixed SonarCloud issues * Add missing command * Add missing is existing check
Alfresco · Nov 3, 2023 · 69c00fc · 69c00fc
1 parent 968febf
commit 69c00fc
Show file tree

Hide file tree

Showing 72 changed files with 327 additions and 530 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -113,7 +113,9 @@
         "@angular-eslint/component-class-suffix": "error",
         "@angular-eslint/directive-class-suffix": "error",
         "@angular-eslint/no-conflicting-lifecycle": "error",
-        "@typescript-eslint/no-floating-promises": "off",
+        "@typescript-eslint/no-floating-promises": "warn",
+        "@typescript-eslint/no-misused-promises": "warn",
+        "@typescript-eslint/default-param-last": "warn",
         "@angular-eslint/no-input-rename": "error",
         "@angular-eslint/no-output-native": "error",
         "@angular-eslint/no-output-on-prefix": "error",
@@ -122,7 +124,7 @@
         "@angular-eslint/no-outputs-metadata-property": "error",
         "@angular-eslint/use-lifecycle-interface": "error",
         "@angular-eslint/use-pipe-transform-interface": "error",
-        "@typescript-eslint/prefer-optional-chain": "warn",
+        "@typescript-eslint/prefer-optional-chain": "error",
         "@typescript-eslint/no-misused-new": "error",
         "@typescript-eslint/no-non-null-assertion": "error",
         "@typescript-eslint/prefer-function-type": "error",
@@ -204,6 +206,7 @@
         "newline-per-chained-call": "off",
         "prefer-rest-params": "error",
         "prefer-spread": "error",
+        "prefer-promise-reject-errors": "error",
         "import/order": "off",
         "max-len": [
           "error",
@@ -226,6 +229,8 @@
         "no-caller": "error",
         "no-global-assign": "error",
         "no-cond-assign": "error",
+        "no-constant-binary-expression": "error",
+        "no-useless-rename": "error",
         "no-console": [
           "error",
           {
@@ -324,7 +329,8 @@
     {
       "files": ["*.spec.ts", "*.test.ts"],
       "rules": {
-        "@typescript-eslint/no-floating-promises": "off",
+        "@typescript-eslint/no-floating-promises": "warn",
+        "@typescript-eslint/no-misused-promises": "warn",
         "max-lines": "off"
       }
     }

diff --git a/app/proxy.conf.js b/app/proxy.conf.js
@@ -18,7 +18,7 @@ module.exports = {
         // workaround for REPO-2260
         onProxyRes: function (proxyRes) {
           const header = proxyRes.headers['www-authenticate'];
-          if (header && header.startsWith('Basic')) {
+          if (header?.startsWith('Basic')) {
               proxyRes.headers['www-authenticate'] = 'x' + header;
           }
       }

diff --git a/app/src/main.ts b/app/src/main.ts
@@ -32,4 +32,4 @@ if (environment.production) {
   enableProdMode();
 }
 
-void platformBrowserDynamic().bootstrapModule(AppModule);
+platformBrowserDynamic().bootstrapModule(AppModule);
diff --git a/docs/index.html b/docs/index.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
     <meta charset="utf-8" />
     <meta http-equiv="X-UA-Compatible" content="IE=edge" />

diff --git a/docs/ja/index.html b/docs/ja/index.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="ja">
   <head>
     <meta charset="utf-8" />
     <meta http-equiv="X-UA-Compatible" content="IE=edge" />

diff --git a/...right/special-permissions-actions-available/src/tests/special-permissions-actions.test.ts b/...right/special-permissions-actions-available/src/tests/special-permissions-actions.test.ts
@@ -108,12 +108,12 @@ test.describe('Special permissions : ', () => {
     await managerSiteActions.addSiteMember(sitePrivate, userCollaborator, Site.RoleEnum.SiteCollaborator);
     await managerSiteActions.addSiteMember(sitePrivate, userDemoted, Site.RoleEnum.SiteManager);
 
-    await managerFileActions.uploadFileWithRename(TEST_FILES.DOCX.path, docLibId, testData.fileDocx.name);
-    fileDocxFavId = (await managerFileActions.uploadFileWithRename(TEST_FILES.DOCX.path, docLibId, testData.fileDocxFav.name)).entry.id;
+    await managerFileActions.uploadFileWithRename(TEST_FILES.DOCX.path, testData.fileDocx.name, docLibId);
+    fileDocxFavId = (await managerFileActions.uploadFileWithRename(TEST_FILES.DOCX.path, testData.fileDocxFav.name, docLibId)).entry.id;
     await managerNodeActions.createFile(testData.file.name, docLibId);
     fileFavId = (await managerNodeActions.createFile(testData.fileFav.name, docLibId)).entry.id;
-    fileDocxSharedId = (await managerFileActions.uploadFileWithRename(TEST_FILES.DOCX.path, docLibId, testData.fileDocxShared.name)).entry.id;
-    fileDocxSharedFavId = (await managerFileActions.uploadFileWithRename(TEST_FILES.DOCX.path, docLibId, testData.fileDocxSharedFav.name)).entry.id;
+    fileDocxSharedId = (await managerFileActions.uploadFileWithRename(TEST_FILES.DOCX.path, testData.fileDocxShared.name, docLibId)).entry.id;
+    fileDocxSharedFavId = (await managerFileActions.uploadFileWithRename(TEST_FILES.DOCX.path, testData.fileDocxSharedFav.name, docLibId)).entry.id;
     fileSharedId = (await managerNodeActions.createFile(testData.fileShared.name, docLibId)).entry.id;
     fileSharedFavId = (await managerNodeActions.createFile(testData.fileSharedFav.name, docLibId)).entry.id;
     fileLockedId = (await managerNodeActions.createFile(testData.fileLocked.name, docLibId)).entry.id;

diff --git a/e2e/playwright/viewer/src/tests/viewer-protected.spec.ts b/e2e/playwright/viewer/src/tests/viewer-protected.spec.ts
@@ -33,7 +33,7 @@ test.describe('viewer file', () => {
   let folderId: string;
   let fileDocxId: string;
 
-  test.beforeAll(async ({ fileAction, shareAction, favoritesPageAction: favoritesPageAction }) => {
+  test.beforeAll(async ({ fileAction, shareAction, favoritesPageAction }) => {
     await apiClientFactory.setUpAcaBackend('hruser');
     const node = await apiClientFactory.nodes.createNode('-my-', { name: randomFolderName, nodeType: 'cm:folder', relativePath: '/' });
     folderId = node.entry.id;