Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments in GHA script #173

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

sjspielman
Copy link
Member

This PR updates a comment I noticed was stale; the code is correct, though.

@sjspielman sjspielman requested a review from jashapiro December 4, 2024 22:39
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I would just take out most of this comment as I don't think it provides any information not in in the code pretty clearly. But if you want to keep it, there are other errors as well as well.

@@ -52,8 +52,8 @@ jobs:
# For each module, the directory of notebooks to copy are:
# Intro R: intro_to_R_tidyverse/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Intro R: intro_to_R_tidyverse/
# Intro R: intro-to-R-tidyverse/

# Advanced scRNA-seq: advanced-scRNA-seq/
# bulk RNA-seq: RNA-seq/
# Advanced scRNA-seq: scRNA-seq-advanced/
# bulk RNA-seq: intro_to_R_tidyverse/, RNA-seq/, and pathway-analysis/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# bulk RNA-seq: intro_to_R_tidyverse/, RNA-seq/, and pathway-analysis/
# bulk RNA-seq: intro-to-R-tidyverse/, RNA-seq/, and pathway-analysis/

@sjspielman
Copy link
Member Author

Honestly, I would just take out most of this comment as I don't think it provides any information not in in the code pretty clearly. But if you want to keep it, there are other errors as well as well.

I would honestly prefer not to keep it as well - not worth maintaining the comments given the clarity of code.

@sjspielman sjspielman merged commit f286f2c into main Dec 11, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/update-gha-comments branch December 11, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants