-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release_tag
to config checklist
#161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may be intentionally not in the list, as we don't update this until much later? The docker tag also probably doesn't get updated yet though...
I think the better thing to do might be to add the docker tag to https://github.com/AlexsLemonade/training-specific-template/blob/main/setup-issue-templates/workshop-release.md?
We will also want to note there (or somewhere) that creating the tag will build a new docker image with a matching tag (this is automatic now!). Which may mean we don't really need a separate docker tag, but it is probably worth leaving them separate for now.
This makes sense to me |
@jashapiro is this about what you had in mind? |
Co-authored-by: Joshua Shapiro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the default in
training-specific-template/_config.yaml
Lines 30 to 31 in a285574
docker_repo: DOCKER-REPOSITORY | |
docker_tag: DOCKER-TAG |
@jashapiro Did you want a default of |
You could. I don't think it matters too much. |
I did it for the pun. Worth it. |
Does what it says! I realized this was missing from the file.
Worth noting this is the first time we're doing a workshop with the updated version of
training-specific-template
so there may be more of these small fixes. Please have a quick look at the config to check that nothing else is missing too - I think we're good now?