386 - Refactor MoveToDatasetButton / MoveToDatasetModal components #435
+107
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in RefinebioContext (during the initial load of the application - replacing the useToken hook) ,and adjusted the other hooks that utilize token
…er viist without activation if it doesn't exist) and use the side effect to sync the token state with acceptedTerms in RefinebioContext, remove the token generation logic from consumer hooks, rename the prop name 'params' to 'body' in interface s methods
…of use checkbox visibility)
… the usage of token/applyAcceptedTerms), and use the token state in hooks instesd (added a new hook useTriggerSubmit - decuple the useEffect until adding conetxt/hook for file download and download options etc)
… accordingly, use this new hook in RefeinbioContext provider and add waitForToken method, use waitForToken in useDatasetManager
… to 'endpoint' for clarity, (minor) remove obsolete interfaces from the api folder
…set in MoveToDatasetButton, rename state/variables for clarity, clean up props, optimize the action methods for the MoveToDatasetModal
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nozomione
requested review from
davidsmejia
and removed request for
davidsmejia
Base automatically changed from
nozomione/413-update-token-validation-flow
to
dev
January 8, 2025 22:19
…-and-modal-components
davidsmejia
reviewed
Jan 24, 2025
| const pathname = '/download' | ||
| const myDatasetTotalSamples = getTotalSamples(myDataset?.data) | ||
|
|
||
| const getRedirect = (prefix) => { |
There was a problem hiding this comment.
Suggested change
| const getRedirect = (prefix) => { | |
| const downloadRedirectWithPrefix = (prefix) => { |
Comment on lines
+47
to
+50
| const handleReplace = async () => { | ||
| await replaceSamples(dataset.data) | ||
| getRedirect('Moved') | ||
| } |
There was a problem hiding this comment.
Suggested change
| const handleReplace = async () => { | |
| await replaceSamples(dataset.data) | |
| getRedirect('Moved') | |
| } | |
| const handlers = { | |
| append: handleAppend, | |
| replace: async () => { | |
| await replaceSamples(dataset.data) | |
| downloadRedirectWithPrefix('Moved') | |
| } | |
| } | |
| const handleSelectAction = (action) => { | |
| await handlers[action]() | |
| // analytics | |
| // close modal | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closes #386
Base branch: PR #421
Purpose/Implementation Notes
I've used an early return to handle the case of no samples in My Dataset, and optimized the action methods (append, replace) of the "Move to Dataset" button.
Types of changes
Functional tests
N/A
Checklist
Screenshots
N/A