Add data release as workflow dispatch option #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaclyn-taroni
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
The code looks good, so I am approving.
Since the primary method of running the openscpca-nf workflow will be via workflow dispatch, I wanted to add the ability to specify a data release to the options there, so this PR does that.
I'm not sure if that's true, but I suppose we will find out.
See my other PR... I'm not sure either! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60
Since the primary method of running the openscpca-nf workflow will be via workflow dispatch, I wanted to add the ability to specify a data release to the options there, so this PR does that. In particular, we may want to run on "future" releases during the process of preparing a new data release.
As with other arguments, the value is passed along via setting an environment variable in the tmux launch script before sending it to AWS.
The release is only used for the
simulateentrypoint or when running the rest of the workflow with real data, to prevent overwriting the prefix for test data.I also added a check that the release prefix is valid, so we don't waste time trying to launch a workflow when the input directory doesn't exist. If that and/or the nextflow pull fails, we report the error and exit.