Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Ruby 3.4.1 #3103

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Test with Ruby 3.4.1 #3103

merged 2 commits into from
Jan 3, 2025

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 14, 2024

Ruby 3.4 has been released

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (e5c2654) to head (51ad85b).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3103      +/-   ##
==========================================
- Coverage   96.58%   96.58%   -0.01%     
==========================================
  Files         236      236              
  Lines        6334     6347      +13     
==========================================
+ Hits         6118     6130      +12     
- Misses        216      217       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen changed the title Test Ruby 3.4.0-rc1 Test with Ruby 3.4.1 Jan 3, 2025
@tvdeyen tvdeyen marked this pull request as ready for review January 3, 2025 17:10
@tvdeyen tvdeyen requested a review from a team as a code owner January 3, 2025 17:10
Ruby 3.4 has been released.
mutex_m and drb are not part of the defaults Gems in
Ruby 3.4 anymore. Since Rails 7.0 and rspec-rails depend
on them, we add it to the local dev Gemfile.
@tvdeyen tvdeyen merged commit 0715733 into AlchemyCMS:main Jan 3, 2025
46 checks passed
@tvdeyen tvdeyen deleted the ruby-3.4 branch January 3, 2025 18:46
@tvdeyen tvdeyen added the backport-to-7.3-stable Needs to be backported to 7.3-stable label Jan 3, 2025
@alchemycms-bot
Copy link
Collaborator

💔 All backports failed

Status Branch Result
7.3-stable An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 3103

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen tvdeyen added backport-to-7.4-stable Needs to be backported to 7.4-stable and removed backport-to-7.3-stable Needs to be backported to 7.3-stable labels Jan 24, 2025
@alchemycms-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
7.4-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.4-stable Needs to be backported to 7.4-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants