Skip to content

Commit

Permalink
fix missing logger issue in github actions
Browse files Browse the repository at this point in the history
concurrent-ruby removed the logger dependency in 1.3.5 and therefore
breaking applications using rails v6.1 up to including v7.0.

Explicitly setting concurrent-ruby to not upgrade beyond v1.3.4 fixes
the issue.

(cherry picked from commit 67adb9a)
  • Loading branch information
robinboening committed Jan 22, 2025
1 parent cbe34df commit 7a2e521
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ group :development, :test do
if rails_version == "7.1"
gem "actioncable", "~> #{rails_version}.0"
end

# concurrent-ruby v1.3.5 has removed the dependency on logger,
# effecting Rails 6.1 up to including 7.0.
# https://github.com/rails/rails/pull/54264
if ("6.1".to_f.."7.0".to_f).cover?(rails_version.to_f)
gem "concurrent-ruby", "< 1.3.5"
end
else
gem "launchy"
gem "annotate"
Expand Down

0 comments on commit 7a2e521

Please sign in to comment.