Skip to content

Commit

Permalink
fixed CSS of the warning section
Browse files Browse the repository at this point in the history
  • Loading branch information
AkashNegi1 committed Dec 14, 2024
1 parent 7c5b0bb commit d11014d
Showing 1 changed file with 25 additions and 10 deletions.
35 changes: 25 additions & 10 deletions modules/ui/commit_warnings.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ import { uiSection } from '../ui/section';
import { utilEntityOrMemberSelector } from '../util';

export function uiCommitWarnings(context) {

var _issuesBySeverity = {};

function commitWarnings(selection) {
// Wrap the selection in a div with the class modal-section
selection = selection.append('div').attr('class', 'modal-section');

// Load issues by severity
_issuesBySeverity = context.validator()
.getIssuesBySeverity({ what: 'edited', where: 'all', includeDisabledRules: true });
Expand All @@ -23,7 +25,7 @@ export function uiCommitWarnings(context) {
if (!issues.length) continue;

// Create a collapsible section for each severity level
var section = uiSection('issues-'+ severity , context)
var section = uiSection('issues-' + severity, context)
.label(() => {
var count = issues.length;
return t.append(
Expand All @@ -38,17 +40,20 @@ export function uiCommitWarnings(context) {
return issues && issues.length;
});

selection.call(section.render);
// Add the appropriate class for styling based on severity
selection
.call(section.render)
.classed(severity + '-section', true);
}
}

function renderIssuesList(selection, severity, issues) {
selection.selectAll('.issues-list').remove();
var container = selection
.append('ul')
.attr('class', 'changeset-list issues-list ' + severity + '-list');
.attr('class', 'layer-list issues-list ' + severity + 's-list');

container.exit().remove();
container.exit().remove();

var items = container.selectAll('li')
.data(issues, function(d) { return d.key; });
Expand All @@ -57,7 +62,7 @@ export function uiCommitWarnings(context) {

var itemsEnter = items.enter()
.append('li')
.attr('class', severity + '-item');
.attr('class', function (d) { return 'issue severity-' + d.severity; });

var buttons = itemsEnter
.append('button')
Expand All @@ -78,11 +83,21 @@ export function uiCommitWarnings(context) {
context.validator().focusIssue(d);
});

buttons
.call(svgIcon('#iD-icon-alert', 'pre-text'));
var textEnter = buttons
.append('span')
.attr('class', 'issue-text');

textEnter
.append('span')
.attr('class', 'issue-icon')
.each(function(d) {
var iconName = '#iD-icon-' + (d.severity === 'warning' ? 'alert' : 'error');
d3_select(this)
.call(svgIcon(iconName));
});

buttons
.append('strong')
textEnter
.append('span')
.attr('class', 'issue-message');

itemsEnter
Expand Down

0 comments on commit d11014d

Please sign in to comment.