Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB04 Improvement of the scopes list view on the Budgets component landing page #1

Merged
merged 9 commits into from
May 19, 2021

Conversation

verarojman
Copy link

@verarojman verarojman commented May 5, 2021

Implements AjuntamentdeBarcelona/decidim-barcelona#360

Task

  • As a visitor, when I reach the Budgets component landing page, I see an improved view of the scopes list with description, budget available and an action button

Specs

  • Title clickable
  • Description shown
  • Budget amount shown
  • Correct text is rendered on buttons

📷 Screenshots

Pre-vote

image

Vote in progress

image

Voted

image

💖 Thank you!

@verarojman verarojman changed the base branch from develop to release/0.24-stable May 5, 2021 14:00
@verarojman verarojman self-assigned this May 5, 2021
@verarojman
Copy link
Author

@carolromero @andreslucena @arnaumonty

Any comments on the screenshots? If it works for you, I'll go ahead and write the specs to finish this PR

@verarojman verarojman changed the base branch from release/0.24-stable to feature/bcn-budget-v0.24 May 5, 2021 14:34
@carolromero
Copy link

Hi @verarojman! Sorry for the delay! We' ve been testing this in the staging environment and we have some suggestions for minor details. Here they go:

  • Remove the outline of the census district (I think that's already fixed right?).

  • Adjust the font size of the budget title to 1.25 rem, for consistency with other titles, and remove the chevron icon from the title.
    image

  • Place the "voted" and "pending votes" icons in this position and with these styles
    image

With these changes we can now move forward and close the PR!

@verarojman verarojman marked this pull request as ready for review May 17, 2021 13:56
@verarojman
Copy link
Author

@carolromero great, I'll deploy it to staging for you to check the changes :)

@carolromero
Copy link

@verarojman this looks good! 😍
For unfinished budgets it might be better to use a single literal, such as "Finish" or "Complete", since on both desktop and mobile the current string breaks the UI a bit:
imatge
Thank you!

@verarojman
Copy link
Author

verarojman commented May 17, 2021

To make the mobile version more readable, I would go for one of these options (I've deployed Option B to staging)

Option A

image

Option B

image

@verarojman verarojman merged commit 553b70a into feature/bcn-budget-v0.24 May 19, 2021
aitorlb pushed a commit to Platoniq/decidim that referenced this pull request Jul 30, 2021
leio10 pushed a commit to decidim/decidim that referenced this pull request Sep 1, 2021
…8249)

* Scopes list improvements on the Budgets component landing page

AjuntamentdeBarcelona#1

* Add spinner when clicking a project

AjuntamentdeBarcelona#10

* Fix modal pop up when project exceeds budget amount

AjuntamentdeBarcelona#13

* Check amount in add to order command

AjuntamentdeBarcelona#14

* Fix 'Add line command'

AjuntamentdeBarcelona#15

* Restyle project vote button

AjuntamentdeBarcelona#16

* Change literal of button when budget is voted

AjuntamentdeBarcelona#17

* Show loading spinner only if no modals will open

5c47ca8

* Fix lint issue

* Fix more lint issues

* Fix lint ERB files errors

* Fix i18n-tasks unused

* Fix decidim-budgets/spec/system/orders_spec.rb

* Fix decidim-budgets/spec/system/explore_budgets_spec.rb

Co-authored-by: Vera Rojman <[email protected]>
Co-authored-by: Ivan Vergés <[email protected]>
Co-authored-by: Vera Rojman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants