Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UDP Realtime streaming in DNRGBW Mode #4499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Christanoid
Copy link

The udp.cpp class contained code to handle dnrgbw as a possible format, however a earlier if filtered out the possibility of actually using that mode due to not accepting the first protocol selection byte being 5 (4 is dnrgb, 5 was already added to be dnrgbw, however then filtered out again)

@Christanoid
Copy link
Author

Note: If this PR goes through smoothly I'll adapt the documentation next to ensure it is also documented on https://kno.wled.ge/interfaces/udp-realtime

@softhack007
Copy link
Collaborator

@Christanoid thanks for your contribution.

As a general matter (applies to all PRs), please don't force-push while you have a PR open for our repo. We regularly lose review comments and have other weird behaviour due to force-pushers. You can simply add (push) commit to your branch, they will be added to the PR and visible to us. Thanks.

Christanoid force-pushed the main branch from b722f7a to 8ee2c44  16 hours ago

@Christanoid
Copy link
Author

I have read the rule on force pushing, sorry for going agianst it, I decided that since the PR was only a few minutes old and it was 1 AM (did not think about timezones, that one's on me), nobody will have seen it yet. Reason for the force push was a bit of local git chaos on my end forcing me to pull from the repo again before committing since my local checked out WLED folder was a bit older, so this PR's history was multiple commits, one of which was unnecessary. I therefore thought I might aswell clean the commit history. Won't do again in the future, once the PR is accepted it will likely get squashed anyways I assume.

@netmindz netmindz added this to the 0.15.1 candidate milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants