Usermod SbusControl #4464
Open
Usermod SbusControl #4464
+138
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a SBusControl UserMod to control brightness and presets via a RC Remote with SBus receiver
Add a SBusControl UserMod to control brightness and presets via a RC Remote with SBus receiver
|
Thank you for your submission. Can you please add a little more detail to your readme file so that users understand exactly what this usermod is for and how to use it please |
DedeHai
reviewed
Feb 1, 2025
| @@ -486,4 +490,8 @@ void registerUsermods() | |||
| #ifdef USERMOD_RF433 | |||
| UsermodManager::add(new RF433Usermod()); | |||
| #endif | |||
|
|
|||
| #ifdef USERMOD_SBUS_CONTROL | |||
| usermods.add(new SbusControl()); | |||
| @@ -250,6 +250,10 @@ | |||
| #include "../usermods/usermod_v2_RF433/usermod_v2_RF433.h" | |||
| #endif | |||
|
|
|||
| #ifdef USERMOD_SBUS_CONTROL | |||
| #include "../usermods/sbus_control/usermod_sbus_control.h" | |||
|
|
||
| uint8_t getSwitchPosition(int16_t ch_value) | ||
| { | ||
| Serial.println(ch_value); |
| uint8_t last_mode_ = 1; | ||
| uint8_t last_bri_ = 1; | ||
|
|
||
| bfs::SbusRx sbus_rx_= {&Serial1, static_cast<int8_t>(sbus_pin_), 0, true}; |
There was a problem hiding this comment.
use pin manager to reserver the pin (or it can be assigned to other functions as well, leading to conflicts)
|
|
||
| void setup() override | ||
| { | ||
| sbus_rx_ = bfs::SbusRx(&Serial1, static_cast<int8_t>(sbus_pin_), 0, true); |
There was a problem hiding this comment.
this will also assign GPIO0 to serial, intentional or an oversight?
also: Serial1 is used by DMX as well. @netmindz can Serial1 be used here without restrictions? If not: there is another UM doing it this way that may need updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a usermod to control WLED via a RCRemote with a sbus receiver connected to an ESP32.
Brightness can be changed.
It can be switched between 9 Presets.