-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard config support for routes / methods #115
Open
tudor-timcu
wants to merge
12
commits into
main
Choose a base branch
from
wildcard
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tudor-timcu
commented
Dec 20, 2024
•
edited
Loading
edited
- Added support for configs that use wildcards when adding routes / method in the Zen dashboard
- Updated rate limiting logic to also maintain counts for the wildcard endpoints (if they match) and provide the rate limiting status back to the request process if threshold is exceeded
- Added support for selecting the most restrictive config from multiple matching ones:
- If at least one force protection off is set to true in all the matching endpoints configs -> the protection is of
- The allowedIPAddresses fields are checked for all the matching routes and if it's found in at least one -> the rest of the checks are bypassed
- Same for checking if the rate limiting is enabled for the current route, if at least one config has rate limiting enabled for the matching endpoints -> we do the gRPC request to get the rate limiting status from agent
- Added E2E tests to check these config selection cases + rate limiting on wildcard routes
tests/server/test_user_rate_limiting_1_minute_for_wildcard_route/env.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.