Increase timeout to 3s and append error message to log

AikidoSec · Jan 27, 2025 · 04f6dbd · 04f6dbd
1 parent 689e46d
commit 04f6dbd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/library/agent/realtime/getConfigLastUpdatedAt.ts b/library/agent/realtime/getConfigLastUpdatedAt.ts
@@ -11,11 +11,15 @@ export async function getConfigLastUpdatedAt(token: Token): Promise<number> {
     headers: {
       Authorization: token.asString(),
     },
-    timeoutInMS: 500,
+    timeoutInMS: 3000,
   });
 
+  if (statusCode === 403) {
+    throw new Error("Token is invalid");
+  }
+
   if (statusCode !== 200) {
-    throw new Error(`Invalid response (${statusCode}): ${body}`);
+    throw new Error(`Expected status code 200, got ${statusCode}`);
   }
 
   const response: RealtimeResponse = JSON.parse(body);

diff --git a/library/agent/realtime/pollForChanges.test.ts b/library/agent/realtime/pollForChanges.test.ts
@@ -226,7 +226,9 @@ t.test("it deals with API throwing errors", async () => {
   await clock.nextAsync();
 
   t.same(configUpdates, []);
-  t.same(logger.getMessages(), ["Failed to check for config updates"]);
+  t.same(logger.getMessages(), [
+    `Failed to check for config updates: Request timed out`,
+  ]);
 
   clock.uninstall();
 });
diff --git a/library/agent/realtime/pollForChanges.ts b/library/agent/realtime/pollForChanges.ts
@@ -41,8 +41,8 @@ export function pollForChanges({
   }
 
   interval = setInterval(() => {
-    check(token, onConfigUpdate).catch(() => {
-      logger.log("Failed to check for config updates");
+    check(token, onConfigUpdate).catch((error) => {
+      logger.log(`Failed to check for config updates: ${error.message}`);
     });
   }, 60 * 1000);