Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#83] 이슈 수정 버그 해결 assignee dto image URL 추가 #84

Merged
merged 6 commits into from
May 3, 2024
Merged

[#83] 이슈 수정 버그 해결 assignee dto image URL 추가 #84

merged 6 commits into from
May 3, 2024

Conversation

minsang-alt
Copy link
Contributor

@minsang-alt minsang-alt commented May 3, 2024 •
edited
Loading

📄 Summary

  • upEpic이 null 인지 확인 하는 로직을 추가했습니다.
  • assignee dto에 카카오 이미지 url도 추가했습니다.
  • db 칼럼명을 member_id -> assignee_id로 수정했습니다.

🕰️ Actual Time of Completion

1시간

🙋🏻 More

  • 칼럼명 변경 이후 native 쿼리등 변경해야 할 부분이 생겨서 다시 assignee_id에서 member_id로 복구 했습니다

@minsang-alt minsang-alt added 🐞 버그 예기치 않은 문제 또는 의도하지 않은 동작에 대한 이슈입니다 🔨 리팩터링 개선사항입니다 labels May 3, 2024
@minsang-alt minsang-alt requested a review from Enble May 3, 2024 05:52
@minsang-alt minsang-alt self-assigned this May 3, 2024
@minsang-alt minsang-alt linked an issue May 3, 2024 that may be closed by this pull request
이슈 수정시 버그 해결 #83
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

Unit Test Results

43 tests   43 ✔️  2s ⏱️
20 suites    0 💤
20 files      0 ❌

Results for commit 3954778.

♻️ This comment has been updated with latest results.

Enble
Enble approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@Enble Enble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minsang-alt minsang-alt merged commit a733e59 into main May 3, 2024
3 checks passed
@minsang-alt minsang-alt deleted the refactor/83 branch May 3, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enble Enble Enble approved these changes

Assignees

@minsang-alt minsang-alt

Labels
🔨 리팩터링 개선사항입니다 🐞 버그 예기치 않은 문제 또는 의도하지 않은 동작에 대한 이슈입니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

이슈 수정시 버그 해결
2 participants
@minsang-alt @Enble