Skip to content

Commit

Permalink
[CI] Add embroider-safe scenario (#1157)
Browse files Browse the repository at this point in the history
* empty

* add embroider-safe, embroider-optimized ember-try scenarios

* deduplicate yarn

* add resolution for @ember/test-waiters because 3.0.1 (reqd by ember-a11y-testing) is not embroider compatible

* yarn deduplicate

* add @ember/string

* add @ember/string v3

* remove embroider pkgs from package.json

* workflow: set fail-fast to false to allow all ember-try to complete

* drop embroider-optimized from ember-try scenarios

* downgrade glimmer/component to v1
  • Loading branch information
bantic authored Jan 8, 2025
1 parent 678d037 commit e19bc5d
Show file tree
Hide file tree
Showing 5 changed files with 807 additions and 1,176 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,12 @@ jobs:
timeout-minutes: 10

strategy:
fail-fast: false
matrix:
ember-version:
[
embroider-safe,
# embroider-optimized,
ember-lts-3.12,
ember-lts-3.20,
ember-lts-3.24,
Expand Down
3 changes: 3 additions & 0 deletions config/ember-try.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint-env node */
const getChannelURL = require('ember-source-channel-url');
const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');

module.exports = function() {
return Promise.all([
Expand All @@ -10,6 +11,8 @@ module.exports = function() {
return {
useYarn: true,
scenarios: [
embroiderSafe(),
embroiderOptimized(),
{
name: 'ember-lts-3.12',
npm: {
Expand Down
3 changes: 2 additions & 1 deletion ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@ module.exports = function(defaults) {
behave. You most likely want to be modifying `./index.js` or app's build file
*/

return app.toTree();
let { maybeEmbroider } = require('@embroider/test-setup');
return maybeEmbroider(app);
};
6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,15 @@
"@addepar/sass-lint-config": "^2.0.1",
"@addepar/style-toolbox": "~0.8.1",
"@ember/optional-features": "^2.0.0",
"@ember/string": "^3.0.0",
"@ember/test-helpers": "^2.8.1",
"@embroider/test-setup": "^4.0.0",
"@glimmer/component": "^1.1.2",
"@tsconfig/ember": "^1.0.1",
"@types/ember__component": "^4.0.10",
"babel-eslint": "^10.0.1",
"broccoli-asset-rev": "^3.0.0",
"ember-a11y-testing": "^5.0.0",
"ember-a11y-testing": "^5.2.1",
"ember-auto-import": "^2.4.2",
"ember-cli": "~3.28.0",
"ember-cli-dependency-checker": "^3.2.0",
Expand Down Expand Up @@ -100,6 +103,7 @@
},
"homepage": "https://Addepar.github.io/ember-table",
"resolutions": {
"@ember/test-waiters": "^3.0.2",
"prettier": "1.18.2"
},
"typesVersions": {
Expand Down
Loading

0 comments on commit e19bc5d

Please sign in to comment.