[trello.com/c/F7EV0pKq] nodes are not enabled alert #643
Conversation
| alert.addAction(showListAction) | ||
| alert.addAction(cancelAction) | ||
|
|
||
| self.present(alert, animated: true, completion: nil) |
There was a problem hiding this comment.
Use ChatDialogManager. Let's not overcomplicate this huge ChatViewController
| @@ -783,6 +784,37 @@ private extension ChatViewController { | |||
| } | |||
| } | |||
|
|
|||
| func checkNodesEnabled() { | |||
There was a problem hiding this comment.
too little logics, let's remove this method
There was a problem hiding this comment.
As Uncle Bob said
If the functions are small it will be easier to comprehend the code. IDK I think that's ideal
| @@ -985,6 +991,9 @@ | |||
| /* Shared alert 'Delete' button. Used anywhere. */ | |||
| "Shared.Delete" = "Удалить"; | |||
|
|
|||
| /* Shared alert 'Review Node List' button. Used on Chat screen. */ | |||
| "Shared.ReviewNodeList" = "К списку узлов ADM"; | |||
|
|
|||
There was a problem hiding this comment.
Add strings for all the other languages as well (use english)
just-software-dev
changed the title
| @@ -199,6 +201,26 @@ private extension ChatDialogManager { | |||
| dialogService.present(alert, animated: true, completion: nil) | |||
| } | |||
|
|
|||
| func showNoEnabledNodesAlert(showAction: @escaping ()->Void) { | |||
| @@ -17,6 +17,7 @@ enum ChatDialog { | |||
| case warning(String) | |||
| case richError(Error) | |||
| case freeTokenAlert | |||
| case noEnabledNodesAlert(()->Void) | |||
There was a problem hiding this comment.
showNodesListAction: () -> Void
There was a problem hiding this comment.
Move it to ChatLocalization, because this alert is used on the chat screen only
| @@ -161,6 +161,7 @@ final class ChatViewController: MessagesViewController { | |||
| defer { viewAppeared = true } | |||
| inputBar.isUserInteractionEnabled = true | |||
| chatMessagesCollectionView.fixedBottomOffset = nil | |||
| checkNodesEnabled() | |||
There was a problem hiding this comment.
Do not show the alert again on the same chat screen. If we close this chat screen and open the same chat screen — it’s counted as another chat screen.
| @@ -199,6 +201,26 @@ private extension ChatDialogManager { | |||
| dialogService.present(alert, animated: true, completion: nil) | |||
| } | |||
|
|
|||
| func showNodeListAlert(showAction: @escaping () -> Void) { | |||
| let alert = UIAlertController( | |||
| title: String.adamant.chat.admNoActiveNodesTitle, | |||
There was a problem hiding this comment.
.adamant.chat.admNoActiveNodesTitle
Purpose of the task is to notify user with alert which appears when entering the chat screen if all nodes are switched off.