trello.com/c/b82n6AMp adding cost to media/files #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1060,6 +1063,29 @@ extension ChatViewModel { | |||
| self?.dateHeaderHidden = true | |||
| } | |||
| } | |||
|
|
|||
| func inputTextFileUpdated() { | |||
|
|
|||
There was a problem hiding this comment.
let's remove this extra space
| @@ -938,6 +938,9 @@ final class ChatViewModel: NSObject { | |||
| } | |||
|
|
|||
| filesPicked = oldFiles | |||
|
|
|||
There was a problem hiding this comment.
let's not add extra spaces between simple lined of code
| filesText = filesPicked.map{ | ||
| ($0.name ?? "") + ($0.extenstion ?? "") | ||
| }.joined(separator: "") | ||
| } |
There was a problem hiding this comment.
let filesText = filesPicked?.map {
[$0.name, $0.extenstion].compactMap { $0 }.joined(separator: ".")
}?.joined(separator: ";") ?? .empty
| @@ -1060,6 +1063,29 @@ extension ChatViewModel { | |||
| self?.dateHeaderHidden = true | |||
| } | |||
| } | |||
|
|
|||
| func inputTextFileUpdated() { | |||
There was a problem hiding this comment.
Let's rename to inputContentUpdated
| @@ -943,6 +943,7 @@ private extension ChatViewController { | |||
| func closeFileToolbarView() { | |||
| filesToolbarView.removeFromSuperview() | |||
| messageInputBar.invalidateIntrinsicContentSize() | |||
| viewModel.inputTextFileUpdated() | |||
There was a problem hiding this comment.
Let's not do it here.
@ObservableValue var filesPicked: [FileResult]?
We can easily observe new files from the ChatViewModel
| "revision": "ac6c0fc9da221873e01bd1a0d4818498a71eef33", | ||
| "version": "4.0.6" | ||
| "revision": "c6bfd1af48efcc9a9ad203665db12375ba6b145a", | ||
| "version": "4.0.8" |
There was a problem hiding this comment.
remove packages updating
| @@ -938,6 +938,8 @@ final class ChatViewModel: NSObject { | |||
| } | |||
|
|
|||
| filesPicked = oldFiles | |||
| inputContentUpdated() | |||
There was a problem hiding this comment.
Remove, because you already have the subscription
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.