This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
feat: make SnappingSheetController listenable #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any pending review issues? Could you merge? |
|
I would appreciate if you could merge this. In case you are looking for maintainers for the project, please communicate this. We'd otherwise publish a fork on pub.dev as we do not want to permanently rely on git imports. |
- implement `Listenable` in SnappingSheetController - use `ValueNotifier` for current position Signed-off-by: TheOneWithTheBraid <[email protected]>
TheOneWithTheBraid
force-pushed
the
listenable
branch
from
3da78ee to
2d9f2a4
Compare
|
@AdamJonsson Could you merge this? It is not such a big change. Otherwise, please tell me what to fix. |
|
@AdamJonsson Could you please merge this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to listen for position changes of the
SnappingSheetController. Might be useful e.g. to transform or animcate the sheet's content based on the current position.The
Listenableoverrides are forwarded to theValueNotifierinside the_SnappingSheetState.Listenablein SnappingSheetControllerValueNotifierfor current positionSigned-off-by: TheOneWithTheBraid [email protected]