Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space - Stephanie #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

stephaniejmars
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in Stephanie, it's well done. You didn't however answer the time/space complexities. Otherwise well done. I particularly like the loop you used to solve inorder. Nice work.

Comment on lines 19 to 21
# Time Complexity:
# Space Complexity:
def add(key, value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , Time & Space Complexity?

Comment on lines 38 to 40
# Time Complexity:
# Space Complexity:
def find(key)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , But what about time/space complexity.

Nice work with the loop solution

Comment on lines 54 to 56
# Time Complexity:
# Space Complexity:
def inorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , But what about time/space complexity.

Wow, doing a loop solution for inorder.

Comment on lines 77 to 79
# Time Complexity:
# Space Complexity:
def preorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , But what about time/space complexity.

Comment on lines 94 to 96
# Time Complexity:
# Space Complexity:
def postorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , Nice work doing the recursive postorder

Comment on lines 115 to 117
# Time Complexity:
# Space Complexity:
def height

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but time/space complexity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants