Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space - Antonia #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

antoniairizarry
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall well done you hit the requirements. Check out my comments regarding the time & space complexities.

Comment on lines +19 to +21
# Time Complexity: O(log n)
# Space Complexity: O(1)
def add_recursive(node, key, value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , However the space complexity is O(log n) if the tree is balanced because of the call stack.

Comment on lines +35 to +37
# Time Complexity: O(log n)
# Space Complexity: O(1)
def find_recursive(node, key)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , However the space complexity is O(log n) if the tree is balanced because of the call stack.

Comment on lines +54 to +56
# Time Complexity: O(n)
# Space Complexity: O(n)
def inorder_recursive(node, list)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +68 to +70
# Time Complexity: O(n)
# Space Complexity: O(n)
def preorder_recursive(node, list)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +82 to +84
# Time Complexity: O(n)
# Space Complexity: O(n)
def postorder_recursive(node, list)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +95 to +97
# Time Complexity: O(n)
# Space Complexity: O(n
def height_recursive(node)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , the space complexity is O(log n) if the tree is balanced and O(n) if it's unbalanced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants