Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emily - Time #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Emily - Time #47

wants to merge 2 commits into from

Conversation

snowistaken
Copy link

@snowistaken snowistaken commented Feb 10, 2020

Assignment Submission: Ride Share

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question Answer
What did your data structure look like at first? Did this structure evolve over time? Why? My data structure did not change significantly over the course of the project. I do feel that I could have simplified it but it was understandable and straightforward enough for me to solve the problems necessary.
What was your strategy for going through the data structure and gathering information? My strategy was to start at the highest level I felt made sense and to process the data from there. Starting at the driver ID I thought about what would be best at the highest level following that.
What was an example of something that was necessary to store in a variable? Why was it necessary, useful, or helpful? I assigned all of the results of each method to their own variable. This was necessary to return the results to the user. Additionally, I assigned each piece of the date to it's own key-value pair so that accessing a specific part of it was more simple.
What kinds of iteration did you use? Did you use .map? If so, when? If not, why, or when would be a good opportunity to use it? I primarily used .each as I completed the project prior to doing the enumerables lesson in class. However, I feel that my approach to each method would be very similar or the same as what I have now regardless of when I had done the project. .each felt the most appropriate for most methods as the majority of the functions were centered around reaching the appropriate level in the data structure.
Were some calculations easier than others? Why? The first calculation was definitely the one that I struggled with the most. This was because I was having a very hard time figuring out exactly how to access the data that I needed. I eventually discovered that I had not been accounting for the fact that the value associated with each driver id was a single hash, and that it did not contain multiple key-value pairs not inside of an additional variable on another level. Once I figured this out all of the calculations were relatively straightforward and much easier.

@snowistaken snowistaken changed the title Create rideshare.rb Emily - Time Feb 11, 2020
@kaidamasaki
Copy link

Ride Share

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates, reads, and modifies variables ✔️
Correctly creates and accesses arrays ✔️
Correctly creates and accesses hashes ✔️
Reasonably organizes large amounts of related data into nested arrays and hashes ✔️
Correctly iterates through a nested data structure using loops and/or Enumerable methods ✔️
Reasonably organizes small pieces of code into methods, and calls/invokes those methods ✔️

Functional Requirements

Functional Requirement yes/no
To the terminal, the program outputs the correct number of rides each driver has given ✔️
... outputs the total amount of money each driver has made ✔️
... outputs the average rating for each driver ✔️
... outputs which driver made the most money ✔️
... outputs which driver has the highest average rating ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 2-3 in Code Review && 2+ in Functional Requirements ✔️
Red (Not at Standard) 0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Just printing out the hashes works, but it would be nice if you'd formatted the output to make it a little prettier. ;)

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable Labels on output would be great.
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants